Function TestAdvisorHappyPath_RootChat

coderd/x/chatd/chatd_test.go:9858–10048

TestAdvisorHappyPath_RootChat walks the advisor tool end-to-end: parent calls advisor alone, the nested advisor call produces text, and the structured result flows back into the parent conversation. The exclusive-policy test above only proves the rejection path; this test covers the glue from chatd

(t *testing.T)

// covers the glue from chatd wiring -> chatadvisor.Tool -> Runtime.Run ->
// nested model call -> structured result back to the outer model.
func TestAdvisorHappyPath_RootChat(t *testing.T) {
	t.Parallel()

	db, ps := dbtestutil.NewDB(t)
	ctx := testutil.Context(t, testutil.WaitLong)

	const advisorReply = "break the problem into smaller pieces first"
	advisorDeltas := []string{"break the problem ", "into smaller pieces first"}

	var (
		streamedCallCount atomic.Int32
		streamedCallsMu   sync.Mutex
		advisorCallSeen   atomic.Bool
		advisorMessages   []chattest.OpenAIMessage
		finalCallMessages []chattest.OpenAIMessage
	)

	openAIURL := chattest.NewOpenAI(t, func(req *chattest.OpenAIRequest) chattest.OpenAIResponse {
		if !req.Stream {
			return chattest.OpenAINonStreamingResponse("title")
		}

		switch streamedCallCount.Add(1) {
		case 1:
			// Parent turn 1: call advisor solo.
			return chattest.OpenAIStreamingResponse(chattest.OpenAIToolCallChunk(
				"advisor",
				`{"question":"how should I approach this refactor?"}`,
			))
		case 2:
			// Nested advisor turn. The nested call has no tools because
			// chatadvisor.RunAdvisor runs with MaxSteps=1 and no tool
			// set.
			require.Empty(t, req.Tools,
				"advisor's nested call must run without tools")
			streamedCallsMu.Lock()
			advisorMessages = append([]chattest.OpenAIMessage(nil), req.Messages...)
			streamedCallsMu.Unlock()
			advisorCallSeen.Store(true)
			return chattest.OpenAIStreamingResponse(
				chattest.OpenAITextChunks(advisorDeltas...)...,
			)
		default:
			// Parent turn 2: observe the advisor tool result and close
			// out with a final text reply.
			streamedCallsMu.Lock()
			finalCallMessages = append([]chattest.OpenAIMessage(nil), req.Messages...)
			streamedCallsMu.Unlock()
			return chattest.OpenAIStreamingResponse(
				chattest.OpenAITextChunks("acknowledged")...,
			)
		}
	})

	user, org, model := seedChatDependenciesWithProvider(t, db, "openai-compat", openAIURL)
	seedAdvisorConfig(ctx, t, db, codersdk.AdvisorConfig{
		Enabled:         true,
		MaxUsesPerRun:   3,