Method doReload

agent/x/agentmcp/manager.go:498–538

doReload reads MCP config files and performs a differential reconnect. Unchanged servers keep their existing client; new or changed servers get a fresh connection; removed servers are closed.

(ctx context.Context, mcpConfigFiles []string)

// changed servers get a fresh connection; removed servers are
// closed.
func (m *Manager) doReload(ctx context.Context, mcpConfigFiles []string) error {
	allConfigs, snap := m.parseAndDedup(ctx, mcpConfigFiles)

	wanted := make(map[string]ServerConfig, len(allConfigs))
	for _, cfg := range allConfigs {
		wanted[cfg.Name] = cfg
	}

	diff, err := m.classifyServers(wanted)
	if err != nil {
		return err
	}

	connected := m.connectAll(ctx, diff.toConnect)

	replaced, err := m.installServers(wanted, diff, connected, snap)
	if err != nil {
		return err
	}

	// Close removed and replaced servers outside the lock to
	// avoid leaking child processes and to avoid blocking
	// concurrent readers on subprocess I/O.
	// Note: a concurrent CallTool that captured a removed
	// entry's client before the swap may call a closed client.
	// This is a narrow race that self-heals on the next request.
	for _, entry := range diff.toClose {
		_ = entry.client.Close()
	}
	for _, entry := range replaced {
		_ = entry.client.Close()
	}

	// Refresh tools outside the lock to avoid blocking
	// concurrent reads during network I/O.
	if err := m.RefreshTools(ctx); err != nil {
		logger := m.logger.With(agentchat.Fields(ctx)...)
		logger.Warn(ctx, "failed to refresh MCP tools after connect", slog.Error(err))
	}
	return nil
}

// parseAndDedup reads all config files and returns a deduplicated
// list of server configs. Missing files are silently skipped;