Function TestRateCutoff

pkg/traceql/engine_metrics_test.go:1169–1276

(t *testing.T)

}

func TestRateCutoff(t *testing.T) {
	start := 1*time.Second + 300*time.Nanosecond // additional 300ns that can be accidentally dropped by ms conversion
	end := 3 * time.Second
	step := end - start
	cutoff := 2*time.Second + 300*time.Nanosecond

	req := tempopb.QueryRangeRequest{
		Start: uint64(start),
		End:   uint64(end),
		Step:  uint64(step),
		Query: "{ } | rate()",
	}
	for _, tc := range []struct {
		name           string
		setInstant     func(req tempopb.QueryRangeRequest) tempopb.QueryRangeRequest
		expectedResult []float64
	}{
		{
			"legacy request (no instant param)",
			func(req tempopb.QueryRangeRequest) tempopb.QueryRangeRequest {
				req.Step = req.End - req.Start
				return req
			},
			// BUG: without instant query provided, instant rate is calculated incorrectly as sum of rates for each sub-interval
			[]float64{(4 / (cutoff - start).Seconds()) + (4 / (end - cutoff).Seconds())},
		},
		{
			"instant query",
			func(req tempopb.QueryRangeRequest) tempopb.QueryRangeRequest {
				req.SetInstant(true)
				return req
			},
			[]float64{8 / step.Seconds()},
		},
		{
			"not instant query",
			func(req tempopb.QueryRangeRequest) tempopb.QueryRangeRequest {
				req.SetInstant(false)
				return req
			},
			// consumes all spans due to step alignment
			[]float64{11 / step.Seconds(), 3 / step.Seconds()},
		},
	} {
		t.Run(tc.name, func(t *testing.T) {
			req = tc.setInstant(req)

			// from start to cutoff
			req1 := req
			req1.End = uint64(cutoff)
			req1 = tc.setInstant(req1)
			// from cutoff to end
			req2 := req
			req2.Start = uint64(cutoff)
			req2 = tc.setInstant(req2)

			in1 := []Span{
				// outside of the range but within the range for ms. Should be ignored for instant queries.