Function ParseIdentifier

pkg/traceql/parse.go:88–118

warning: ParseIdentifier is used to parse filter policies in pkg/spanfilter/config/config.go if changed, it can break existing config. Behavioral note vs. the previous implementation: this now rejects identifiers containing unquoted spaces (e.g. ".foo bar") that were previously accepted via HasPref

(s string)

// unquoted spaces (e.g. ".foo bar") that were previously accepted via HasPrefix matching.
// Quoted identifiers with spaces (e.g. span."foo bar") are still accepted.
func ParseIdentifier(s string) (Attribute, error) {
	// Wrap the identifier in curly braces to create a valid spanset filter expression
	attr := "{" + s + "}"
	expr, err := ParseNoOptimizations(attr)
	if err != nil {
		return Attribute{}, fmt.Errorf("failed to parse identifier %s: %w", s, err)
	}

	// Validate the parsed expression structure
	if expr == nil {
		return Attribute{}, fmt.Errorf("failed to parse identifier %s: parsed expression is nil", s)
	}

	if len(expr.Pipeline.Elements) == 0 {
		return Attribute{}, fmt.Errorf("failed to parse identifier %s: no pipeline elements found", s)
	}

	// Extract and validate the spanset filter
	filter, ok := expr.Pipeline.Elements[0].(*SpansetFilter)
	if !ok {
		return Attribute{}, fmt.Errorf("failed to parse identifier %s: expected SpansetFilter but got %T", s, expr.Pipeline.Elements[0])
	}

	// Extract and validate the attribute
	attribute, ok := filter.Expression.(Attribute)
	if !ok {
		return Attribute{}, fmt.Errorf("failed to parse identifier %s: expected Attribute but got %T", s, filter.Expression)
	}

	return attribute, nil
}

func MustParseIdentifier(s string) Attribute {
	a, err := ParseIdentifier(s)